add rpc to query raft status #3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kikimo
requested review from
yixinglu,
sherman-the-tank,
critical27 and
liuyu85cn
Codecov Report
@@ Coverage Diff @@
## master #3336 +/- ##
==========================================
- Coverage 85.31% 85.25% -0.07%
==========================================
Files 1289 1279 -10
Lines 120073 119010 -1063
==========================================
- Hits 102442 101459 -983
+ Misses 17631 17551 -80
Continue to review full report at Codecov.
|
yixinglu
reviewed
Nov 24, 2021
| STOPPED = 2; // The part has been stopped | ||
| WAITING_SNAPSHOT = 3; // Waiting for the snapshot. | ||
| } | ||
|
|
There was a problem hiding this comment.
These enum types have been defined in following source file, could you unify the usage of these enum types?
nebula/src/kvstore/raftex/RaftPart.h
Lines 239 to 252 in b7c6901
There was a problem hiding this comment.
@yixinglu updated, PTAL
critical27
reviewed
Nov 25, 2021
src/interface/raftex.thrift
Outdated
| CANDIDATE = 3; // Has sent AskForVote request | ||
| LEARNER = 4; // same with FOLLOWER, except that it does | ||
| // not vote in leader election | ||
| } |
There was a problem hiding this comment.
could add a (cpp.enum_strict) here and below
critical27
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
This PR add an readonly raft rpc
getState()to query raft info like: leadership, running status, current term and etc. We expect this rpc to help us find the correct leader as soon as possible when leader change happends during our test, it's a replacement for meta api which has high latency and sometime return incorrect leader information.