Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 3317 #3325

Merged
merged 4 commits into from
Nov 19, 2021
Merged

fix issue 3317 #3325

merged 4 commits into from
Nov 19, 2021

Conversation

cangfengzhs
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

close issue 3317

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatible (If it is incompatible, please describe it and add corresponding label.)
  • Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:

                                                            `

@cangfengzhs cangfengzhs added the ready-for-testing PR: ready for the CI test label Nov 18, 2021
@cangfengzhs cangfengzhs linked an issue Nov 18, 2021 that may be closed by this pull request
@cangfengzhs cangfengzhs marked this pull request as ready for review November 18, 2021 03:17
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #3325 (4642c5d) into master (21582a1) will decrease coverage by 0.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3325      +/-   ##
==========================================
- Coverage   85.24%   85.22%   -0.02%     
==========================================
  Files        1289     1289              
  Lines      119979   119982       +3     
==========================================
- Hits       102275   102257      -18     
- Misses      17704    17725      +21     
Impacted Files Coverage Δ
src/storage/exec/IndexEdgeScanNode.cpp 91.75% <71.42%> (-0.81%) ⬇️
src/storage/exec/IndexVertexScanNode.cpp 89.47% <71.42%> (-0.94%) ⬇️
src/common/thrift/ThriftClientManager-inl.h 82.97% <0.00%> (-6.39%) ⬇️
...eta/processors/session/SessionManagerProcessor.cpp 74.19% <0.00%> (-4.52%) ⬇️
src/kvstore/raftex/Host.cpp 71.90% <0.00%> (-4.02%) ⬇️
src/graph/session/GraphSessionManager.cpp 79.88% <0.00%> (-1.73%) ⬇️
src/kvstore/raftex/RaftPart.cpp 72.87% <0.00%> (-1.20%) ⬇️
src/common/meta/ServerBasedSchemaManager.cpp 82.29% <0.00%> (-1.05%) ⬇️
src/storage/query/QueryBaseProcessor-inl.h 84.21% <0.00%> (-0.47%) ⬇️
src/clients/storage/GraphStorageClient.cpp 73.11% <0.00%> (-0.19%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6eb04...4642c5d. Read the comment docs.

@cangfengzhs cangfengzhs requested a review from a team November 19, 2021 02:37
@critical27 critical27 merged commit 4dd4a26 into vesoft-inc:master Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage core
4 participants