support gql list/set/map #3302
Merged
support gql list/set/map #3302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jievince
added
ready-for-testing
nevermore3
reviewed
Nov 11, 2021
| | 0 | 0 | 0 | | ||
| When executing query: | ||
| """ | ||
| RETURN 1 IN LIST[] AS a, "Tony" IN SET{} AS b, "a" IN MAP{} AS c |
There was a problem hiding this comment.
could you add some nested cases， such as MAP{a: LIST[1,2], b: SET{1,2,1}, c: "hee"}
jievince
force-pushed
the
gql-list
branch
2 times, most recently
from
e36ad29 to
fb3b67c
Compare
Codecov Report
@@ Coverage Diff @@
## master #3302 +/- ##
==========================================
+ Coverage 85.25% 85.27% +0.01%
==========================================
Files 1279 1276 -3
Lines 118989 119005 +16
==========================================
+ Hits 101445 101477 +32
+ Misses 17544 17528 -16
Continue to review full report at Codecov.
|
nevermore3
approved these changes
Nov 15, 2021
CPWstatic
reviewed
Nov 16, 2021
| @@ -1191,12 +1192,27 @@ list_expression | |||
| : L_BRACKET expression_list R_BRACKET { | |||
| $$ = ListExpression::make(qctx->objPool(), $2); | |||
| } | |||
| | KW_LIST L_BRACKET opt_expression_list R_BRACKET { | |||
There was a problem hiding this comment.
Is this the syntax proposed in the GQL draft？
There was a problem hiding this comment.
Yes, but strangely, according to the syntax of gql, it still seems that empty list/set/map is not allowed.
Shylock-Hg
added
the
incompatible
czpmango
approved these changes
Nov 22, 2021
CPWstatic
approved these changes
Nov 29, 2021
Sophie-Xie
removed
the
incompatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2894