[Fix] if propNames is empty, replaceDefaultValue may wrong. #3025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Mgr may core while shutdown
liuyu85cn
added
ready-for-testing
critical27
reviewed
Oct 11, 2021
critical27
approved these changes
Oct 11, 2021
critical27
requested review from
critical27,
bright-starry-sky,
cangfengzhs,
darionyaphet,
liwenhui-soul,
SuperYoko and
panda-sheep
critical27
approved these changes
Oct 12, 2021
| @@ -348,10 +351,6 @@ void StorageServer::stop() { | |||
| if (adminServer_) { | |||
| adminServer_->stop(); | |||
| } | |||
| if (txnMan_) { | |||
There was a problem hiding this comment.
dose the close order have some effect ?
Codecov Report
@@ Coverage Diff @@
## master #3025 +/- ##
==========================================
- Coverage 84.34% 84.20% -0.15%
==========================================
Files 1283 1287 +4
Lines 113684 115350 +1666
==========================================
+ Hits 95891 97133 +1242
- Misses 17793 18217 +424
Continue to review full report at Codecov.
|
Sophie-Xie
pushed a commit
that referenced
this pull request
Oct 13, 2021
…Mgr may core while shutdown (#3025) Co-authored-by: CBS <[email protected]>
critical27
pushed a commit
that referenced
this pull request
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fix delete kv store before txnMan_ (may core)