Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can tag name be identical to an edge type name within the same space #598

Closed
jude-zhu opened this issue Jul 9, 2019 · 1 comment · Fixed by #652
Closed

Can tag name be identical to an edge type name within the same space #598

jude-zhu opened this issue Jul 9, 2019 · 1 comment · Fixed by #652
Assignees
@laura-ding
Milestone
R201910_beta

Comments

@jude-zhu
Copy link
Contributor

jude-zhu commented Jul 9, 2019

I defined an edge type named player2 , then created a tag named player2 in the same space successfully.

image

Should the name be unique within one space?
@sherman-the-tank
Copy link
Member

Good point 👍

I don't think we should allow tag name and edge type to share the same name.

One solution is to let the meta service check during the creation and return error if the name has been used

@dangleptr

@sherman-the-tank sherman-the-tank added this to the R201910_beta milestone Jul 10, 2019
@laura-ding laura-ding self-assigned this Jul 17, 2019
@laura-ding laura-ding mentioned this issue Jul 18, 2019
Merged
@dutor dutor closed this as completed in #652 Aug 2, 2019
dutor pushed a commit that referenced this issue Aug 2, 2019
@laura-ding @dutor
Fix the same name tag and edge in same space #598 (#652)
0e3150c 
* Fix the same name tag and edge in same space #598

* Fix show tags or edges have many same tags or edge #650

* Address dutor's comment

* Rebase upstream

* Modify default install path
yixinglu pushed a commit to yixinglu/nebula that referenced this issue Feb 16, 2020
@laura-ding @dutor
Fix the same name tag and edge in same space vesoft-inc#598 (vesoft-i…
123a77b 
…nc#652)

* Fix the same name tag and edge in same space vesoft-inc#598

* Fix show tags or edges have many same tags or edge vesoft-inc#650

* Address dutor's comment

* Rebase upstream

* Modify default install path
tong-hao pushed a commit to tong-hao/nebula that referenced this issue Jun 1, 2021
@laura-ding @dutor
Fix the same name tag and edge in same space vesoft-inc#598 (vesoft-i…
0e85e6f 
…nc#652)

* Fix the same name tag and edge in same space vesoft-inc#598

* Fix show tags or edges have many same tags or edge vesoft-inc#650

* Address dutor's comment

* Rebase upstream

* Modify default install path
yixinglu pushed a commit to yixinglu/nebula that referenced this issue Mar 21, 2022
@nebula-bots @critical27
[kvstore] adjust log level and add header comments (vesoft-inc#3681) (v…
43334f8 
…esoft-inc#598)

* adjust log level

* add header comments

* address comments

* address @wenhaocs's comments

* rebased, code format

confirm with critical27

Co-authored-by: Doodle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laura-ding laura-ding

Labels
None yet
Projects
None yet
Milestone
R201910_beta
Development

Successfully merging a pull request may close this issue.

Fix the same name tag and edge in same space #598
3 participants
@sherman-the-tank @laura-ding @jude-zhu