Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Service Crashed when execute http put flags interface. #4398

Closed
Milittle opened this issue Jul 11, 2022 · 5 comments
Closed

The Service Crashed when execute http put flags interface. #4398

Milittle opened this issue Jul 11, 2022 · 5 comments
Labels
severity/major Severity of bug type/bug Type: something is unexpected
Milestone
v3.2.0

Comments

@Milittle
Copy link
Contributor

Milittle commented Jul 11, 2022 •
edited
Loading

Describe the bug (required)

When execute the follow command: For graphd and sotraged both have problem.

curl -X PUT xxx.xxx.xxx.xxx:19559/flags. this curl command has the empty body.

the service will be crashed.

So I have one solution for this:

Before this line

nebula/src/webservice/SetFlagsHandler.cpp

Line 42 in 7a7ab68

std::string body = body_->moveToFbString().toStdString();
, maybe we should add new verification for the body_, I think we meet the nullptr exception cause the service crashed.
@Milittle Milittle added the type/bug Type: something is unexpected label Jul 11, 2022
@wey-gu
Copy link
Contributor

wey-gu commented Jul 12, 2022

@xiajingchun is this the one we already know or a new pattern that crashes with WS port?

@Sophie-Xie Sophie-Xie added this to the v3.2.0 milestone Jul 12, 2022
@xiajingchun
Copy link

@wey-gu unfortunately this one is not the same. Thanks @Milittle to point it out. We should be able to fix it soon.

@wey-gu
Copy link
Contributor

wey-gu commented Jul 12, 2022 •
edited
Loading

@Milittle would you like to help fix it, one background here is we hopefully to include this in 3.2.0 cycle(is about to be released very soon).

@Milittle
Copy link
Contributor Author

include this in 3.2.0 cycle(is about to be released very soon).

Sure, I will pull new request tonight

Milittle added a commit to Milittle/nebula that referenced this issue Jul 12, 2022
@Milittle
Fix storage crash(issue:vesoft-inc#4398)
ea18e10 
* when we use flags put interface, but we does not specify the body.
* The sotrage will be crashed.
For example:
curl -X PUT xxx.xxx.xxx.xxxx:19559/flags
@Milittle Milittle mentioned this issue Jul 12, 2022
Merged
3 tasks
Milittle added a commit to Milittle/nebula that referenced this issue Jul 12, 2022
@Milittle
Fix web service crash(issue:vesoft-inc#4398)
e94f6b5 
* when we use flags put interface, but we does not specify the body.
* The service will be crashed.
For example:
curl -X PUT xxx.xxx.xxx.xxxx:19559/flags
critical27 pushed a commit that referenced this issue Jul 13, 2022
@Milittle
Fix web service crash(issue:#4398) (#4405)
7ce81ee 
* when we use flags put interface, but we does not specify the body.
* The service will be crashed.
For example:
curl -X PUT xxx.xxx.xxx.xxxx:19559/flags
Sophie-Xie pushed a commit that referenced this issue Jul 13, 2022
@Milittle @Sophie-Xie
Fix web service crash(issue:#4398) (#4405)
490f5a2 
* when we use flags put interface, but we does not specify the body.
* The service will be crashed.
For example:
curl -X PUT xxx.xxx.xxx.xxxx:19559/flags
@wey-gu
Copy link
Contributor

wey-gu commented Jul 13, 2022

Thank you so much @Milittle!

@wey-gu wey-gu closed this as completed Jul 13, 2022
critical27 pushed a commit that referenced this issue Jul 13, 2022
@Sophie-Xie @Milittle @dutor
Cherry pick 3.2.0 (0712-0713) (#4408)
324d134 
* Fix web service crash(issue:#4398) (#4405)

* when we use flags put interface, but we does not specify the body.
* The service will be crashed.
For example:
curl -X PUT xxx.xxx.xxx.xxxx:19559/flags

* Fix delete vertex or edge, the storage crashed.(#4397) (#4406)

* When our space has tag index or edge index.
* When delete vertex or edge, we specify one vid more than our defined
  in space.
* The sotrage will be crashed.

Solution:
1. Add vid valid verfication.

Co-authored-by: Sophie <[email protected]>

* Release with separate debug info in ELF format (#4400)

Co-authored-by: Milittle <[email protected]>
Co-authored-by: dutor <[email protected]>
@wey-gu wey-gu mentioned this issue Jul 16, 2022
Closed
@jinyingsunny jinyingsunny added the severity/major Severity of bug label Nov 11, 2022
yixinglu pushed a commit to yixinglu/nebula that referenced this issue Jan 31, 2023
@nebula-bots @Milittle
Fix web service crash(issue:vesoft-inc#4398) (vesoft-inc#1084)
5ee2d44 
* when we use flags put interface, but we does not specify the body.
* The service will be crashed.
For example:
curl -X PUT xxx.xxx.xxx.xxxx:19559/flags

Co-authored-by: Milittle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity/major Severity of bug type/bug Type: something is unexpected
Projects
None yet
Milestone
v3.2.0
Development

No branches or pull requests
5 participants
@wey-gu @xiajingchun @Milittle @Sophie-Xie @jinyingsunny