metaclient timeout use paramter from configs #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks again for your contribution, please make code format first~ |
Nicole00
reviewed
Oct 22, 2021
| @@ -15,10 +15,10 @@ import com.vesoft.nebula.meta.{PropertyType, Schema} | |||
| import scala.collection.JavaConverters._ | |||
| import scala.collection.mutable | |||
|
|
|||
| class MetaProvider(addresses: List[Address]) extends AutoCloseable { | |||
| class MetaProvider(addresses: List[Address], timeout: Int, connectionRetry: Int, executionRetry: Int) extends AutoCloseable { | |||
There was a problem hiding this comment.
parameters are changed, please sync the test code to make the compile works.
There was a problem hiding this comment.
PropertyType.GEOGRAPHY not exists ，how to fix it
There was a problem hiding this comment.
The PropertyType.GEOGRAPHY has been supported in the latest java client, maybe your local maven repo is old. If you use IDEA, you can config it through preferences -> Build,Execution,Deployment -> Build tools -> Maven， choose Always update snapshots
|
Hi liyanl, you need to modify the Instantiate of MetaProvider in MetaProviderTest file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.