Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logger to every task #203

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Add logger to every task #203

merged 1 commit into from
Mar 31, 2022

Conversation

xjlgod
Copy link
Contributor

@xjlgod xjlgod commented Mar 28, 2022 •
edited
Loading

Studio need log file to support every task. Adjust the log framework of the importer.

@xjlgod xjlgod requested a review from yixinglu as a code owner March 28, 2022 11:47
@xjlgod xjlgod changed the title [WIP] Add logger to every task Add logger to every task Mar 31, 2022
@xjlgod xjlgod force-pushed the log branch 2 times, most recently from a8b7863 to a030419 Compare March 31, 2022 06:49
yixinglu
yixinglu approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yixinglu yixinglu merged commit e7281cc into vesoft-inc:master Mar 31, 2022
@jamieliu1023 jamieliu1023 mentioned this pull request Apr 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yixinglu yixinglu yixinglu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xjlgod @yixinglu