This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Fix the mistake that yield validator mistake check the input/var. #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shylock-Hg
added
bug
yixinglu
reviewed
Jun 24, 2021
yixinglu
reviewed
Jul 2, 2021
| | 1 | | ||
| | 1 | | ||
| | 1 | | ||
| | 1 | | ||
| When executing query: | ||
| """ | ||
| GO FROM "Tim Duncan" OVER * | YIELD 1 AS a WHERE true; | ||
| """ | ||
| Then the result should be, in any order: | ||
| | a | | ||
| | 1 | |
There was a problem hiding this comment.
I want to know what's the right result should be ? @CPWstatic
Should the number of results be same as the edges from Tim Duncan ?
There was a problem hiding this comment.
According to the origin code, I guess it may want to set input to the inner var when the all expressions of yield columns are constant. So I change it to this.
Shylock-Hg
added
doc affected
jievince
reviewed
Jul 7, 2021
| | "Manu Ginobili" | | ||
| | "Manu Ginobili" | | ||
| | "Manu Ginobili" | | ||
| | "Manu Ginobili" | |
There was a problem hiding this comment.
The result of $var[row][col] is not a cell?
There was a problem hiding this comment.
Yes, it's not constant expr.
|
Move to vesoft-inc/nebula#2789 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close https://github.com/vesoft-inc/nebula-graph/issues/1169