-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ShowSpaces for Session #315
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #315 +/- ##
==========================================
- Coverage 64.73% 64.59% -0.14%
==========================================
Files 11 11
Lines 2705 2723 +18
==========================================
+ Hits 1751 1759 +8
- Misses 810 817 +7
- Partials 144 147 +3 ☔ View full report in Codecov by Sentry. |
BTW, there is no tests for the ConnPool ~ |
So can we move the methods into |
7dffe66
to
051c775
Compare
051c775
to
ceadc67
Compare
ceadc67
to
692981f
Compare
Add Show spaces and for
67a473d
to
e52e4a0
Compare
Sorry for reply late. I think it's ok to provide the method for |
The reason for this is that we often use ConnPool to init the space but not the SessionPool
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: