Add some schema helper methods for SessionPool #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoxins
force-pushed
the
session_pool_helpers
branch
from
2a349c9 to
bbc39d8
Compare
haoxins
force-pushed
the
session_pool_helpers
branch
from
bbc39d8 to
9a29ba0
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #312 +/- ##
==========================================
+ Coverage 63.17% 63.69% +0.51%
==========================================
Files 9 10 +1
Lines 2466 2570 +104
==========================================
+ Hits 1558 1637 +79
- Misses 778 795 +17
- Partials 130 138 +8 ☔ View full report in Codecov by Sentry. |
Nicole00
reviewed
Feb 2, 2024
label.go
Outdated
| type LabelFieldSchema struct { | ||
| Field string | ||
| Type string | ||
| Null bool |
There was a problem hiding this comment.
IsNull is better for bool var name?
There was a problem hiding this comment.
I change it to Nullable
| Default string `nebula:"Default"` | ||
| Comment string `nebula:"Comment"` | ||
| } | ||
|
|
There was a problem hiding this comment.
we can define LabelName here to represent the result of show tags/show edges.
Nicole00
reviewed
Feb 2, 2024
| @@ -0,0 +1,78 @@ | |||
| package nebula_go | |||
There was a problem hiding this comment.
please add copyright for new files.
Nicole00
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
#311
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: