Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copyrights&logo/favicon/pdf/github link changes for yueshu website #2763

Merged
merged 1 commit into from
May 16, 2023
Merged

copyrights&logo/favicon/pdf/github link changes for yueshu website #2763

merged 1 commit into from
May 16, 2023

Conversation

abby-cyber
Copy link
Contributor

No description provided.

copyright&logo/favicon-changes-for-yueshu

Update mkdocs.yml

Update mkdocs.yml
@abby-cyber abby-cyber changed the title copyrights&logo/favicon changes for yueshu website copyrights&logo/favicon/pdf/github link changes for yueshu website May 15, 2023
Copy link
Contributor

@whitewum whitewum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit messages and code changes align with each other.
Overall, the code changes look good and achieve the stated goals in the commit messages.
Here are some specific feedback points:
In the mkdocs.yml file:
The site_url has been updated to https://ent-docs.nebula-graph.com.cn/.
The docs_dir has been updated to docs-2.0.
The copyright has been updated for both the site and the repository.
The repo_name and repo_url remain the same.
The theme section has been modified to include a new logo and favicon for the site.
The cover_logo has been updated in the plugins > pdf section.
The site-specific changes:
The site name, description, and author have been updated for the Yueshu Graph Database.
The Yueshu specific logo and favicon have been added.
The repository-specific changes:
The site name, description, and author have been updated for the NebulaGraph Database.
The NebulaGraph specific logo and favicon have been added.
The edit_uri and version sections have been left unchanged.

The plugins > pdf > author section has been updated with new names.

The plugins > pdf > cover_logo has been updated for both the common and Yueshu sections.

Overall, the changes seem to be in line with updating the necessary information, logos, and URLs for the Yueshu Graph Database website. The commit message accurately describes the purpose of the changes. No bugs or major issues are apparent in the code changes. Well done!

@whitewum whitewum merged commit 8ba4282 into vesoft-inc:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants