Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

middleware: add assets handler #17

Merged
merged 1 commit into from
May 11, 2022
Merged

Conversation

veezhang
Copy link
Contributor

  • add middleware pkg with assets handler
  • 100% test coverage

@veezhang veezhang requested a review from nianiaJR May 11, 2022 08:51
@codecov-commenter
Copy link

Codecov Report

Merging #17 (2a7fae0) into master (97328dd) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #17   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        14    +1     
  Lines          624       689   +65     
=========================================
+ Hits           624       689   +65     
Impacted Files Coverage Δ
middleware/assets.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97328dd...2a7fae0. Read the comment docs.

Copy link
Contributor

@nianiaJR nianiaJR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veezhang veezhang merged commit a180a93 into vesoft-inc:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants