Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publish_npm.sh to publish Github releases #110

Merged
merged 1 commit into from
Jan 7, 2023
Merged

Update publish_npm.sh to publish Github releases #110

merged 1 commit into from
Jan 7, 2023

Conversation

sitingren
Copy link
Member

Use Github REST API to publish a Github release when we are publishing packages to npm.

@sitingren sitingren requested a review from DMickens December 21, 2022 07:20
echo "[Success] Detected version to be published: $version"
fi

if [ -z "$GITHUB_TOKEN" ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't thought about using an environment variable locally. This will save me some time

Copy link
Collaborator

@DMickens DMickens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for doing this in my absence. It completely slipped my mind

@sitingren sitingren merged commit 6718ac2 into vertica:master Jan 7, 2023
@sitingren sitingren deleted the github-release branch January 7, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants