Online image change: handling of the standby subcluster #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 16, 2021 11:06
roypaulin
reviewed
Dec 16, 2021
api/v1beta1/verticadb_types.go
Outdated
|
|
||
| // +kubebuilder:validation:Optional | ||
| // +operator-sdk:csv:customresourcedefinitions:type=spec,xDescriptors="urn:alm:descriptor:com.tectonic.ui:hidden" | ||
| // If a standby, this is the name of the primary subcluster it is a standby |
There was a problem hiding this comment.
Isn't there a missing word on this line?
There was a problem hiding this comment.
How about this?
// If this is a standby, this is the name of the primary subcluster the
// subcluster was created for. This is state internally managed for
// an online image change.
There was a problem hiding this comment.
Yeah I think it is better. Maybe because my english is no so good but I feel like having 2 consecutive occurrences of subscluster is repetitive. What do you think about:
// If this is a standby subcluster, this is the name of the primary subcluster
// it was created for. This is state internally managed for
// an online image change.
roypaulin
reviewed
Dec 16, 2021
| Annotations: makeAnnotationsForObject(vdb), | ||
| }, | ||
| Spec: appsv1.StatefulSetSpec{ | ||
| Selector: &metav1.LabelSelector{ | ||
| MatchLabels: makeSvcSelectorLabels(vdb, scHandle), | ||
| MatchLabels: makeSvcSelectorLabels(vdb, sc), |
There was a problem hiding this comment.
Is sticking to sc instead of scHandle only due to the fact that vapi.Subcluster is already passed around?
There was a problem hiding this comment.
Yes, so this undoes some of the work that I did earlier. Overall, I think it makes it simpler.
|
looks good. let's wait for the checks. |
|
looks good. Thanks. |
roypaulin
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another PR for online-upgrade. It will handle creation and removal of the standby subcluster during the online-image change process.