Flow subcluster info for online-upgrade process #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also renames ImageChangeInitiator to ImageChangeManager to handle its larger scope.
This will allow us to distinguish primary vs secondary vs standby
This will allow us to reuse obj_reconcile to build the standby subcluster.
roypaulin
reviewed
Dec 13, 2021
roypaulin
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The online-upgrade process needs more information about the subcluster. This introduces a new data structure SubclusterHandle that has the Subcluster struct that is stored in etcd plus additional runtime info that is needed for the online-upgrade process.
There is two parts to this change. First is fetching the additional information through sc_finder. The second is flowing the new SubclusterHandle through various functions.
In a subsequent PR, I will start to fill out some of the functions in onlineupgrade_reconcile.go using the data collected in SubclusterHandle.