Add scaffolding for online image change #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also renames ImageChangeInitiator to ImageChangeManager to handle its larger scope.
|
Looks good. Could you tell me more about all this online image change? |
|
Thanks. I'll setup a meeting to discuss |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sketches out the flow for the online image change. Online image change is still not functional, but it lays out the structure of the code that I will fill in on subsequent PRs.
This also does more refactoring. There were additional changes I wanted to reuse in offlineimagechange_reconcile.go. Those were moved to ImageChangeInitiator, and that struct was renamed to ImageChangeManager.