Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize installation experience on windows #6

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Optimize installation experience on windows #6

merged 2 commits into from
Apr 25, 2024

Conversation

zhu0629
Copy link
Contributor

@zhu0629 zhu0629 commented Apr 24, 2024

No description provided.

@zhu0629 zhu0629 requested a review from aooohan April 24, 2024 09:32
Copy link
Member

@aooohan aooohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thank you so much for such a great contribution! 👍👍👍

I will test it on Windows later.

lib/util.lua Outdated Show resolved Hide resolved
Copy link
Member

@aooohan aooohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Test passed!

@aooohan aooohan merged commit 5b1f24c into main Apr 25, 2024
6 checks passed
@aooohan aooohan deleted the dev branch April 25, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants