-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frameworks][examples] Add RedwoodJS #4539
Conversation
@@ -0,0 +1,7 @@ | |||
[web] | |||
port = 8910 | |||
apiProxyPath = "/.netlify/functions" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea…
const Routes = () => { | ||
return ( | ||
<Router> | ||
<Route notfound page={NotFoundPage} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a Home Page here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redwood will display a page similar to the way Rails & Blitz.js do to say it's working. We could add one ourselves to this app but it'll work without as well
Co-authored-by: Steven <[email protected]>
@@ -0,0 +1,7 @@ | |||
[web] | |||
port = 8910 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to change the port here to use the $PORT
environment variable? We need a way for vercel dev
to assign the port dynamically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not sure—there’s a decent chance we’ll need to just talk to the Redwood team directly, they haven’t optimized for anything but Netlify yet
### Changes - Add new Runtime: `@vercel/redwood` - Update `run.js` script to sort packages properly ### Related - Related to #4539 - Related to #4535 - Depends on apollographql/apollo-server#4311
Closing in favor of #4915 |
- Supersedes #4539 - Related to #4676 Co-authored-by: Lachlan Campbell <[email protected]>
Adding Redwood to the frameworks list, static builders file, & an example app for it.
Waiting on the creation of a Redwood builder to merge.