Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(turborepo): Add top-level rust cargo files to cli deps #5348

Merged
merged 3 commits into from
Jun 21, 2023
Merged

fix(turborepo): Add top-level rust cargo files to cli deps #5348

merged 3 commits into from
Jun 21, 2023

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Jun 21, 2023 •
edited
Loading

Description

  • Our rust build depends on Cargo.toml / Cargo.lock
  • Remove GO_TAG from our deps
  • Remove GO_TAG from the env vars for test.yml
  • Add windows Go binary to outputs

Testing Instructions

@gsoltis gsoltis requested a review from arlyon June 21, 2023 15:27
@gsoltis gsoltis requested a review from a team as a code owner June 21, 2023 15:27
@gsoltis gsoltis requested a review from chris-olszewski June 21, 2023 15:27
@vercel
Copy link

vercel bot commented Jun 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 6:11pm
examples-native-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 6:11pm
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2023 6:11pm
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2023 6:11pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2023 6:11pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2023 6:11pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2023 6:11pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2023 6:11pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2023 6:11pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2023 6:11pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2023 6:11pm

@gsoltis gsoltis requested a review from a team as a code owner June 21, 2023 15:57
@gsoltis gsoltis requested review from NicholasLYang and removed request for chris-olszewski June 21, 2023 15:57
@github-actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions
Copy link
Contributor

Linux Benchmark for d843aaa

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 6240.78µs ± 29.56µs 6576.93µs ± 250.30µs +5.39%
bench_hmr_to_eval/Turbopack CSR/1000 modules 5868.58µs ± 39.65µs 5968.38µs ± 216.63µs +1.70%
bench_startup/Turbopack CSR/1000 modules 922.61ms ± 1.50ms 924.63ms ± 2.23ms +0.22%

NicholasLYang
NicholasLYang approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@NicholasLYang NicholasLYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing GO_TAG as a dependency? Cause we're not gonna flip it anymore?

@gsoltis
Copy link
Contributor Author

gsoltis commented Jun 21, 2023

@NicholasLYang I think we're done flipping it, but also some workflows set it, and others don't. We build with it either way.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

Linux Benchmark for 46dc23e

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 11.86ms ± 0.07ms 11.77ms ± 0.09ms -0.76%
bench_hmr_to_eval/Turbopack CSR/1000 modules 10.70ms ± 0.03ms 11.01ms ± 0.37ms +2.89%
bench_startup/Turbopack CSR/1000 modules 1159.55ms ± 4.46ms 1174.90ms ± 6.08ms +1.32%

@gsoltis gsoltis assigned gsoltis and unassigned gsoltis Jun 21, 2023
@gsoltis gsoltis enabled auto-merge (squash) June 21, 2023 19:03
@gsoltis gsoltis merged commit 8f3ec2c into main Jun 21, 2023
@gsoltis gsoltis deleted the gsoltis/cli_deps branch June 21, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicholasLYang NicholasLYang NicholasLYang approved these changes

@arlyon arlyon Awaiting requested review from arlyon

Assignees
No one assigned
Labels
area: ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsoltis @NicholasLYang