docs: mentioned missing info regarding putting npm organization while… #3513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… importing workspace For coherence on the page, I mentioned the missing information of adding the npm organization or user space as well if it is there in the imported workspace's `package.json` file as part of it's `name` during import of a workspace in another workspace. For example, if it is `@mycompany/shared-utils` instead of `shared-utils`. This case is not mentioned in the Workspaces which depend on each other' section. Currently the 'Workspaces which depend on each other' section only explains the case where npm organization or user space is not part of the imported workspace's `name`
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Ignored Deployments
|
|
@mbsc26 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
the
area: docs
|
Hey @mbsc26! Thank you for the PR. We explicitly specify the name of the package in a previous step in this walkthrough. If the user chooses to add a namespace to the package name we assume that they're also capable of knowing that they will need to further adjust the following steps accordingly. {
"name": "shared-utils"
}I'm going to close this as it is advanced usage beyond what we intend to cover in our walkthrough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… importing workspace
For coherence on the page, I mentioned the missing information of adding the npm organization or user space as well if it is there in the imported workspace's
package.jsonfile as part of it'snameduring import of a workspace in another workspace.For example, if it is
@mycompany/shared-utilsinstead ofshared-utils.This case is not mentioned in the 'Workspaces which depend on each other' section.
Currently the 'Workspaces which depend on each other' section only explains the case where npm organization or user space is not part of the imported workspace's
name