Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for release to clarify questions. #1766

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Update docs for release to clarify questions. #1766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ jobs:
# Optional: working directory, useful for monorepos
working-directory: cli

# Optional: golangci-lint command line arguments.
# `golangci-lint-action` does not have an "install only" option.
# We ignore the output of this run, instead using it just to install the binary.
args: --issues-exit-code=0

- uses: pnpm/[email protected]
Expand Down
7 changes: 3 additions & 4 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,11 @@ If you're using a different package manager replace npm accordingly.

## Publishing `turbo` to the npm registry

Canary builds are automatically published when code is merged to the `main` branch.
See the [`release` Github workflow](./.github/workflows/release.yml).
All builds are handled by manually triggering the appropriate [`release` GitHub workflow](./.github/workflows/release.yml).

To manually release:
To manually run a release:

1. `brew install goreleaser`
2. Add `GORELEASER_KEY` env var with the Go Releaser Pro key (ask @turbo-oss to get access to the key)
2. Add `GORELEASER_KEY` env var with the GoReleaser Pro key (ask @turbo-oss to get access to the key)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @tknickman @mehulkar

I see you.

3. Update `version.txt` (do not commit this change to git manually)
4. `cd cli && make publish`
2 changes: 2 additions & 0 deletions cli/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ publish: clean prepublish build
cd $(CLI_DIR)/../packages/create-turbo && npm publish --tag $(TURBO_TAG)
cd $(CLI_DIR)/../packages/turbo-codemod && npm publish --tag $(TURBO_TAG)

# Force push to ensure that the version used for the release is published.
# This _intentionally_ clobbers. If it does so, redo the clobbered thing.
git push -f origin main "v$(TURBO_VERSION)"

demo/lage: install
Expand Down