feat(otel): add deployment ID resource attribute #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mthines
approved these changes
Jul 2, 2024
dvoytenko
reviewed
Aug 16, 2024
dvoytenko
approved these changes
Aug 20, 2024
|
@bripkens huge thanks! the change has been released in 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Through log drain's
deploymentIdfield it is possible to link log records to a specific Vercel deployment.It would be great if the same level of linking could be established for OTLP data on Vercel. If that were the case, OTLP and log drain information could be correlated to the same "resource" (in OpenTelemetry terminology).
What
Report
vercel.deployment_idas a resource attribute.