Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace docker-compose v1 command with docker compose v2 #38505

Closed
wants to merge 3 commits into from

Conversation

maxproske
Copy link
Contributor

Replace legacy docker-compose command with docker compose (no hyphen) in all examples #36283 (review)

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue was opened via the examples template. label Jul 11, 2022
@balazsorban44
Copy link
Member

balazsorban44 commented Jul 11, 2022

I wonder in which version of Docker this was added or if any additional changes are necessary to get it working. I'm on Docker version 20.10.17, build 100c701 and docker compose yields:

docker: 'compose' is not a docker command.
See 'docker --help'

https://docs.docker.com/engine/release-notes/#201017 This is a ~month old release

@Yhozen
Copy link

Yhozen commented Jul 15, 2022

@balazsorban44 the beta is more than a year old and compose is a docker cli plugin now. I have been using it for more than 4 months now without any problem

@balazsorban44
Copy link
Member

balazsorban44 commented Jul 15, 2022

hmm, so it's not part of docker by default but a plugin you have to install in addition. should we mention that since people might run into this like me? this wasn't clear for me. at least docker-compose is obvious if missing.

@Yhozen
Copy link

Yhozen commented Jul 15, 2022

@balazsorban44 it installed by default on Docker Desktop version but not on the Linux cli version 🤷🏻‍♂️ weird decisions

@maxproske maxproske changed the title Replace docker-compose v1 command with docker compose v2 Replace docker-compose v2 command with docker compose v1 Jul 23, 2022
@maxproske maxproske changed the title Replace docker-compose v2 command with docker compose v1 Replace docker-compose v1 command with docker compose v2 Jul 23, 2022
@maxproske maxproske closed this Jul 23, 2022
@maxproske
Copy link
Contributor Author

Closing until Docker allows us to alias docker compose to docker-compose

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants