Port 'with-static-export' example to TypeScript #38268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawncal
requested review from
timneutkens,
ijjk,
shuding,
leerob,
steven-tey and
balazsorban44
as code owners
|
@maintainers Let me know if you'd prefer updating the existing with-static-export example to use TS instead of adding this new with-static-export-typescript example alongside it. |
|
@shawncal Looks like converting existing examples to TypeScript is preferred - no need for a separate TypeScript example. #37682 (review) |
balazsorban44
previously requested changes
Jul 6, 2022
There was a problem hiding this comment.
#38268 (comment) is correct. Let's just convert the existing example. 👍 Thanks!
shawncal
changed the title
# Conflicts: # examples/with-static-export/.gitignore
ijjk
approved these changes
Aug 7, 2022
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'with-static-export' example is very useful but, if a developer wants to use TypeScript, converting it is nontrivial. There are some gotchas in the GetStaticProps/GetStaticPaths functions. This example should help jumpstart TS development for sites static generation.
Documentation / Examples
pnpm lint