do not use window.history if inside iframe #3437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunoda
suggested changes
Dec 14, 2017
There was a problem hiding this comment.
Good catch.
In this case of inside a frame, Next's history based routing won't work.
So, user should not use Next's routing inside a frame.
Yes we should not throw an error. But we should warn the user in the dev mode.
(use execOnce and warn for this)
* Add a nerv example. * Fix for indentation/style * Fix for name
|
Hi again! I just now added the warning using execOnce as you suggested. |
|
Thank you very much @hankmander 🙏 |
|
Thank you guys for being responsive to requests and maintaining an awesome project! 😄 |
|
❤️ |
|
@timneutkens It says above "timneutkens merged commit b8f189f into zeit:canary on 4 Feb” but it seems this is not in Next.js 7.0.2? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks if next.js is run inside an iframe in which case it does not use window.history. I do not see how history makes sense in the context of being embedded in another site anyway.
Fixes this crash that prevented next.js from working at all in an iframe: #3118