Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beta 8: pages reload in dev mode after compilation #2147

Closed
fionawhim opened this issue Jun 2, 2017 · 7 comments
Closed

beta 8: pages reload in dev mode after compilation #2147

fionawhim opened this issue Jun 2, 2017 · 7 comments

Comments

@fionawhim
Copy link
Contributor

Something I just noticed after upgrading from beta 6 to beta 8. In dev mode, clicking a Link to an uncompiled page causes a reload of the current page.

Repro:

  • Click a <Link> wrapping an <a> to a page that hasn't been compiled yet

What should happen:

  • Page compiles
  • You go to that page

What does happen:

  • Page compiles
  • New page appears briefly
  • Browser reloads the previous page's URL

Seeing this in Chrome. I'm noticing that the server is showing a 200 to the previous page's URL, so it's a full page load rather than just re-rendering client side.

@gragland
Copy link

gragland commented Jun 3, 2017

I'm also seeing this issue on beta 8 and beta 9.

@MindRave
Copy link

MindRave commented Jun 4, 2017

Yep, seeing the same thing here. (running on beta9)

@starburst997
Copy link

Also have this problem on 2.4.1 (was fine on 2.4.0)

@arunoda
Copy link
Contributor

arunoda commented Jun 5, 2017

Fixed with #2171

@arunoda arunoda closed this as completed Jun 5, 2017
@gragland
Copy link

Still seeing this problem on beta 13.

@gragland
Copy link

gragland commented Jun 17, 2017

@MindRave @finneganh Are you also still seeing this issue with the latest beta?

EDIT: Okay problem solved. For some reason NPM was installing beta 9 even with "next": "^3.0.0-beta16" in my package.json and doing a fresh npm install (after deleting /npm_modules and package-lock.json). I had to do npm install next@beta --save to get beta 16. With the latest beta I'm no longer seeing this issue.

@fionawhim
Copy link
Contributor Author

fionawhim commented Jun 23, 2017 via email

@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants