Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify use of getStaticProps / getServerSideProps with app / document #17828

Closed
leerob opened this issue Oct 12, 2020 · 2 comments · Fixed by #17839
Closed

Clarify use of getStaticProps / getServerSideProps with app / document #17828

leerob opened this issue Oct 12, 2020 · 2 comments · Fixed by #17839
Labels
good first issue Easy to fix issues, good for newcomers

Comments

@leerob
Copy link
Member

leerob commented Oct 12, 2020

Feature request

Describe the solution you'd like

We currently don't explicitly mention you can't use getStaticProps or getServerSideProps with _app.js or _document.js in the docs. These proposals are still in RFC.

We should add a note to both the app and document section of the docs to mention this.

Additional context

https://nextjs.org/docs/advanced-features/custom-app
@leerob leerob added good first issue Easy to fix issues, good for newcomers type: documentation labels Oct 12, 2020
@paambaati paambaati mentioned this issue Oct 13, 2020
Merged
@kodiakhq kodiakhq bot closed this as completed in #17839 Oct 13, 2020
kodiakhq bot pushed a commit that referenced this issue Oct 13, 2020
@paambaati
docs: Clarify use of getStaticProps / getServerSideProps with app / d…
f1b3818 
…ocument (#17839)

Fixes #17828.

This change adds a caveat to both the "Custom `App`" and "Custom `Document`" pages about how both `getStaticProps` and `getServerSideProps` aren't supported.
@leerob
Copy link
Member Author

leerob commented Oct 13, 2020

Thank you thank you @paambaati 🙏

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Easy to fix issues, good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Clarify use of getStaticProps / getServerSideProps with app / document
2 participants
@leerob @balazsorban44