next-codemod: add empty pnpm-workspace.yaml to test fixtures to byp…

…ass PNPM workspace checks (#71726) ### Why? Since dep installation within next-codemod runs `pnpm install` on the Next.js repo, it installs in the workspace root scope during testing. We could add a layer for testing like adding a flag `--no-workspace`, but it will reduce confidence between the actual running and testing. Therefore added an empty `pnpm-workspace.yaml` file to each fixture. ### How? By doing this, both installation and testing will have same environment of running, `pnpm install` only. To prevent created `pnpm-lockfile` to be shipped, gitignored it. This way, we keep things simple and make sure tests match real-world use better. The empty `pnpm-workspace.yaml` files make `pnpm` treat each fixture separately, which is closer to how it'll work for users.
vercel · Oct 23, 2024 · 741f830 · 741f830
1 parent aed6c4c
commit 741f830
Show file tree

Hide file tree

Showing 14 changed files with 2 additions and 1 deletion.
diff --git a/packages/next-codemod/bin/__testfixtures__/.gitignore b/packages/next-codemod/bin/__testfixtures__/.gitignore
@@ -0,0 +1 @@
+pnpm-lock.yaml
diff --git a/packages/next-codemod/bin/__testfixtures__/geo-ip-usage/pnpm-workspace.yaml b/packages/next-codemod/bin/__testfixtures__/geo-ip-usage/pnpm-workspace.yaml
diff --git a/packages/next-codemod/bin/__testfixtures__/next-14-installed/pnpm-workspace.yaml b/packages/next-codemod/bin/__testfixtures__/next-14-installed/pnpm-workspace.yaml
diff --git a/packages/next-codemod/bin/__testfixtures__/next-15-canary-43-installed/pnpm-workspace.yaml b/packages/next-codemod/bin/__testfixtures__/next-15-canary-43-installed/pnpm-workspace.yaml
diff --git a/packages/next-codemod/bin/__testfixtures__/next-15-canary-44-installed/pnpm-workspace.yaml b/packages/next-codemod/bin/__testfixtures__/next-15-canary-44-installed/pnpm-workspace.yaml
diff --git a/packages/next-codemod/bin/__testfixtures__/no-geo-ip-usage/pnpm-workspace.yaml b/packages/next-codemod/bin/__testfixtures__/no-geo-ip-usage/pnpm-workspace.yaml
diff --git a/packages/next-codemod/bin/__testfixtures__/peer-dep-out-of-range/pnpm-workspace.yaml b/packages/next-codemod/bin/__testfixtures__/peer-dep-out-of-range/pnpm-workspace.yaml
diff --git a/...ges/next-codemod/bin/__testfixtures__/react-18-installed-mixed-router/pnpm-workspace.yaml b/...ges/next-codemod/bin/__testfixtures__/react-18-installed-mixed-router/pnpm-workspace.yaml
diff --git a/.../next-codemod/bin/__testfixtures__/react-18-installed-pure-app-router/pnpm-workspace.yaml b/.../next-codemod/bin/__testfixtures__/react-18-installed-pure-app-router/pnpm-workspace.yaml
diff --git a/...ext-codemod/bin/__testfixtures__/react-18-installed-pure-pages-router/pnpm-workspace.yaml b/...ext-codemod/bin/__testfixtures__/react-18-installed-pure-pages-router/pnpm-workspace.yaml
diff --git a/...ges/next-codemod/bin/__testfixtures__/react-19-installed-mixed-router/pnpm-workspace.yaml b/...ges/next-codemod/bin/__testfixtures__/react-19-installed-mixed-router/pnpm-workspace.yaml
diff --git a/.../next-codemod/bin/__testfixtures__/react-19-installed-pure-app-router/pnpm-workspace.yaml b/.../next-codemod/bin/__testfixtures__/react-19-installed-pure-app-router/pnpm-workspace.yaml
diff --git a/...ext-codemod/bin/__testfixtures__/react-19-installed-pure-pages-router/pnpm-workspace.yaml b/...ext-codemod/bin/__testfixtures__/react-19-installed-pure-pages-router/pnpm-workspace.yaml
diff --git a/packages/next-codemod/scripts/test-upgrade-fixture.sh b/packages/next-codemod/scripts/test-upgrade-fixture.sh
@@ -11,7 +11,7 @@ cd "$1" || exit 1
 # We're only interested in the changes the upgrade command does.
 git add -A .
 rm -rf node_modules
-pnpm install --ignore-workspace --no-lockfile
+pnpm install
 node "$NEXT_CODEMOD_BIN" upgrade "${@:2}"
 git --no-pager diff .
 git restore .