Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support debug option #363

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Support debug option #363

merged 1 commit into from
Apr 29, 2019

Conversation

guybedford
Copy link
Contributor

This adds a --debug flag to the CLI and a debugLog option to the API for logging asset emission reasons.

Useful for debugging why assets are being emitted by the build.

@guybedford guybedford requested a review from styfle as a code owner April 28, 2019 18:58
@codecov-io
Copy link

Codecov Report

Merging #363 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #363   +/-   ##
=======================================
  Coverage   74.61%   74.61%           
=======================================
  Files          12       12           
  Lines         386      386           
=======================================
  Hits          288      288           
  Misses         98       98
Impacted Files Coverage Δ
src/cli.js 62.35% <ø> (ø) ⬆️
src/index.js 84.47% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d601ac1...1d68063. Read the comment docs.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but you also need to add to the README.md file 😄

@styfle styfle merged commit 643cabb into master Apr 29, 2019
@styfle styfle deleted the debug branch April 29, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants