Multiple fixes for the CLI #5328
Merged
+84
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use sudo-prompt to create symlink with sudo if required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don't allow the use of
Tools>Add Hyper CLI to PATHoption on linux, this pr enables that.Using
sudo-promptwe can create the symlink for the cli if/usr/local/binis owned by root (generally the case in linux)When using AppImage, it's run from a temporary squashfs mount point, we can't create the symlink for this path as it'll change on next run. Instead, I've added injection of cli path in that case.
Sometimes
/usr/local/binmight not exist, I've added creation of that dir if it doesn't exist.Fixes #4750
Fixes #5307
Fixes #2829
Fixes #2849
Most of the problems with cli not being installed should be fixed with this
users might need to use the
Add Hyper CLI to PATHoption if it's not installed by default