Fix onFinal callback argument when a string is returned from tool call. #961
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an inconsistent behaviour of
onFinal
callback when different types are returned fromexperimental_onToolCall
.When
experimental_onToolCall
callback returns a stream,onFinal
gets called with a complete response of the returned stream. However, whenexperimental_onToolCall
returns a string,onFinal
callback is called with the tool call instead of the returned string.This PR makes the behaviour consistent -
onFinal
is called with the string returned fromexperimental_onToolCall
.