Ensure the ManageNSG rule is always removed. #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whatever happens in between Adding the NSG Rule and Removing the NSG rule may fail. With this addition, any failed action will always remove the rule created regardless of the success of the steps before it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an update to your README for the suggested GitHub Action tasks.
Whatever happens in between Adding the NSG Rule and Removing the NSG rule may fail. With this addition, any failed action will always remove the rule created regardless of the success of the steps before it. Without this, manual or automated CI/CD deployments or tests may result in hundreds of additional NSG rules added by ManageNSG if they happen to fail after the NSG rule addition but before the NSG rule removal.