Add support for the --no-color option. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `colored` gem was replaced with `colorize`. It has a very similar API but comes with a few extra methods to remove or check colors. The Tabber class has had an options hash added to it, to make further additions easier.
| Synx::Tabber.increase(3) | ||
| expect(Kernel).to_not receive(:puts) | ||
| Synx::Tabber.puts("Hello, world.") | ||
| end | ||
|
|
||
| it "should not print colors if no_color is true" do |
There was a problem hiding this comment.
Is there a test for the opposite case, where it prints colors when no_color is false? :)
There was a problem hiding this comment.
@marklarr There isn't, but I'll add one right now!
|
This is great. Thanks for the PR! |
|
|
|
Thanks @samsymons! |
ayanonagon
added a commit
that referenced
this pull request
Jun 30, 2014
Add support for the --no-color option.
|
Thanks @samsymons! This is awesome. 🎈 |
|
Thanks for the superb gem, happy to be able to contribute! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
coloredgem was replaced withcolorize. It has a very similar API but comes with a few extra methods to remove or check colors.The Tabber class has had an options hash added to it, to make further additions easier.
This partially addresses issue #28.