-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds useful message when test panics on no return values #736
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #736 +/- ##
===================================================
- Coverage 75.25042% 75.16639% -0.08403%
===================================================
Files 9 10 +1
Lines 2396 2404 +8
===================================================
+ Hits 1803 1807 +4
- Misses 455 459 +4
Partials 138 138 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. I'll approve for now and give it one last look later today and merge once the tests pass (coverage might fail but I'm going to remove that check, it's not entirely useful). Thanks for the contribution ❤️
Awesome! Thanks for your patience and support @LandonTClipp! |
Description
Adds a useful message when the test panics on no return value.
Fixes Omitting
.Return()
on an expectation results in a panic and a stack trace rather than a useful error message #729Type of change
Version of Golang used when building/testing:
How Has This Been Tested?
I tested by using Unit tests
Checklist