-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add include-regex
option
#692
Conversation
@LandonTClipp - I'm not super familiar with the codebase or coding style so feel free to make any suggestions/changes. Thanks for your time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, I actually don't have any concerns. It's basically exactly how I would have implemented it. Thanks for taking the time to do this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, just one minor doc change and we should be set.
``` | ||
|
||
??? note "all: true" | ||
Using `all: true` will override `include-regex` and issue a warning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually one thing I did miss, you'll want to also include this parameter in the configuration
section of the docs in that large table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs updated 👍 I took the liberty of reformatting the markdown tables so they are easily readable in raw text. Can revert that if you want.
@LandonTClipp Is there anything else you'd like adding to this or are we good to go? Thanks 🙏 |
Nothing else I think we need, I'll give it one last look this Monday and merge if it looks good. Sorry, I have been on an extended camping trip out west and have not been focusing on coding much 😄 |
Description
Prior to packages configuration, it was possible to pass a regex to filter which interfaces are considered for mocking. This reintroduces the feature using the
include-regex
option for package configurations.Example config:
In addition to this feature, a number of variables named
packages
have been renamed topackageList
as they were clashing with package names.--name
doesn't accept regex values #684Type of change
Version of Golang used when building/testing:
How Has This Been Tested?
Tests have been added to
config_test.go
. These test the following scenarios:Client
are generatedChecklist