Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec support for latest draft version #342

Merged
merged 8 commits into from
Jan 27, 2025

Conversation

CodingContraption
Copy link
Contributor

@CodingContraption CodingContraption commented Jan 27, 2025

Fixes #341: Update gqlparser to support the graphql-js reference

The validator/imported/graphql-js-commit.log Git ref of 48afd37a48d37f6d3342b959e8cb34e1ecbfeffb is https://github.com/graphql/graphql-js/releases/tag/v16.10.0

I have:

  • Added tests covering the bug / feature
  • Updated any relevant documentation

@coveralls
Copy link

coveralls commented Jan 27, 2025

Coverage Status

coverage: 87.519% (+0.2%) from 87.316%
when pulling d0cb275 on CodingContraption:master
into 217e304 on vektah:master.

readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@StevenACoffman StevenACoffman merged commit 4de5ffd into vektah:master Jan 27, 2025
5 checks passed
@StevenACoffman
Copy link
Collaborator

@CodingContraption Thank you so much! As I mentioned in your issue, if you can describe the process you followed to manually update the prelude.graphql it would really help me, as I'm trying to automate it using the graphql-js reference implementation or spec document, instead of my current "feels right to me" ad hoc approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing support for deprecated field arguments & input type fields
3 participants