Rename enable_mime() to enable() #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the
vf.enable_mime()function to simplyvf.enable().This is to remove an early point of confusion for users who aren't familiar with the term mime(type). There is still a
mimetypeargument to the function, but it will default tohtmlso a user isn't forced to deal with it in most cases.The
enable_widget()function stays as is. I considered merging it intovf.enable(), but the widget renderer has several distinct configuration options that would complicate the signature ofvf.enablewith options that are only valid for the widget renderer.