Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bigint support #1828

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

marcus-josendal
Copy link
Contributor

@marcus-josendal marcus-josendal commented Dec 5, 2023

Transforms the bigint type to { type: 'number' }. If you try to transform bigint today you will get this error:

UnknownNodeError: Unknown node " bigint" of kind "BigIntKeyword".

bigint is a primtive type added in Typescript 3.2.

Version

Published prerelease version: v1.5.0-next.0

Changelog

🎉 This release contains work from a new contributor! 🎉

Thank you, Marcus Jøsendal (@marcus-josendal), for all your work!

🚀 Enhancement

🔩 Dependency Updates

Authors: 2

@domoritz
Copy link
Member

domoritz commented Dec 5, 2023

Thanks. An alternative to this would have been to implement a new BigIntTypeNodeParser but that seems overkill here until we do something special (like saying that bigints are represented as strings in JSON).

@domoritz domoritz merged commit f5cb7c0 into vega:next Dec 5, 2023
4 checks passed
Copy link

github-actions bot commented Dec 5, 2023

🚀 PR was released in v1.5.0 🚀

@github-actions github-actions bot added released This issue/pull request has been released. and removed prerelease labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants