Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix first deploy cluster creation #76

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Fix first deploy cluster creation #76

merged 2 commits into from
Oct 19, 2023

Conversation

MatheusdeMelo
Copy link
Contributor

Fix the ECS cluster creation in the first deploy on CodeBuild.

fagianijunior
fagianijunior reviewed Oct 13, 2023
View reviewed changes
provision.sh Outdated Show resolved Hide resolved
fagianijunior
fagianijunior reviewed Oct 13, 2023
View reviewed changes
provision.sh Outdated Show resolved Hide resolved
fagianijunior
fagianijunior requested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@fagianijunior fagianijunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to remove the unnecessary comment on code.

@MatheusdeMelo
Copy link
Contributor Author

MatheusdeMelo commented Oct 18, 2023 •
edited
Loading

Needs to remove the unnecessary comment on code.

With the commit "Remove comments" this request has be changed.

fagianijunior
fagianijunior approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@fagianijunior fagianijunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

]ok

@fagianijunior fagianijunior merged commit bf46094 into main Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fagianijunior fagianijunior fagianijunior approved these changes

@fagiani fagiani Awaiting requested review from fagiani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatheusdeMelo @fagianijunior