Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit scope width #49

Merged
merged 1 commit into from
May 18, 2023
Merged

limit scope width #49

merged 1 commit into from
May 18, 2023

Conversation

iri6e4k0
Copy link
Contributor

@iri6e4k0 iri6e4k0 commented Apr 5, 2023

По умолчанию:
scope_width =-1 - не сокращаем
scope_width = N- сокращаем от N символов

и накинула на эти комбинации тесты

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -2.60 ⚠️

Comparison is base (bf6cc18) 94.60% compared to head (ee9f1e5) 92.01%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   94.60%   92.01%   -2.60%     
==========================================
  Files         112      131      +19     
  Lines        2690     3283     +593     
  Branches      266      345      +79     
==========================================
+ Hits         2545     3021     +476     
- Misses        126      238     +112     
- Partials       19       24       +5     
Impacted Files Coverage Δ
...edro/plugins/director/pycharm/_pycharm_reporter.py 100.00% <100.00%> (ø)
vedro/plugins/director/rich/_cut_str.py 100.00% <100.00%> (ø)
vedro/plugins/director/rich/_rich_printer.py 90.50% <100.00%> (+0.12%) ⬆️
vedro/plugins/director/rich/_rich_reporter.py 97.43% <100.00%> (+0.05%) ⬆️

... and 49 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tsv1 tsv1 self-requested a review April 10, 2023 07:42
@iri6e4k0 iri6e4k0 force-pushed the long-str-2 branch 2 times, most recently from 6a778aa to 51ccc6e Compare May 17, 2023 03:06
@tsv1 tsv1 changed the title fixed Limit scope width May 18, 2023
@tsv1 tsv1 changed the title Limit scope width limit scope width May 18, 2023
@tsv1
Copy link
Member

tsv1 commented May 18, 2023

LGTM

@tsv1 tsv1 merged commit d0bb8f2 into vedro-universe:master May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants