Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance plugin system with dependency management #118

Merged
merged 14 commits into from
Jan 7, 2025
Merged

Conversation

tsv1
Copy link
Member

@tsv1 tsv1 commented Jan 5, 2025

Resolves #117

Introduce a depends_on attribute for plugins to define dependencies, enabling automatic ordering and validation of plugin load sequences.

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 16 lines in your changes missing coverage. Please review.

Project coverage is 90.68%. Comparing base (37425fc) to head (152fc9e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
vedro/commands/run_command/_run_command.py 85.29% 3 Missing and 2 partials ⚠️
vedro/_config.py 75.00% 4 Missing ⚠️
vedro/commands/run_command/_plugin_registrar.py 96.92% 1 Missing and 1 partial ⚠️
.../scenario_discoverer/_multi_scenario_discoverer.py 50.00% 1 Missing and 1 partial ⚠️
vedro/core/scenario_result/_aggregated_result.py 0.00% 1 Missing and 1 partial ⚠️
vedro/events/__init__.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   90.72%   90.68%   -0.04%     
==========================================
  Files         165      168       +3     
  Lines        4742     4874     +132     
  Branches      672      693      +21     
==========================================
+ Hits         4302     4420     +118     
- Misses        381      395      +14     
  Partials       59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsv1 tsv1 changed the title Plugin dependencies Enhance plugin system with dependency management Jan 5, 2025
@tsv1 tsv1 marked this pull request as ready for review January 6, 2025 20:45
@tsv1 tsv1 merged commit 8a0479e into main Jan 7, 2025
8 checks passed
@tsv1 tsv1 deleted the plugin-dependencies branch January 7, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Make plugin dependencies explicit in configuration
1 participant