chore(tests): Split Receiver::cancel out of Receiver::wait
#3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits
crate::test_util::Receiver::waitmethod intowaitandcancel. Somel of the usages of this method were having a race as they were expecting that the method wouldwaitfor thetcpchannel to close, which wasn't the case. Instead the method was canceling the channel which caused a race. Only test that needs thecancelwastcp_stream.Similar how in #2862
crate::test_util::CountReceiver::waitwas split.Ref. #2978
Fixes
test_max_size_resume