Set a default MDOP (#250)

vcsjones · May 12, 2024 · 64b8ec3 · 64b8ec3
2 parents 061517c + 92e467a
commit 64b8ec3
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/AzureSignTool/Program.cs b/src/AzureSignTool/Program.cs
@@ -79,7 +79,7 @@ internal sealed class SignCommand : Command
         internal bool NoPageHashing { get; set; }
         internal bool ContinueOnError { get; set; }
         internal string? InputFileList { get; set; }
-        internal int? MaxDegreeOfParallelism { get; set; }
+        internal int MaxDegreeOfParallelism { get; set; } = 4;
         internal bool Colors { get; set; }
         internal bool SkipSignedFiles { get; set; }
         internal bool AppendSignature { get; set; }
@@ -266,9 +266,9 @@ private async ValueTask<int> RunSign()
                     logger.LogInformation("Cancelling signing operations.");
                 };
                 var options = new ParallelOptions();
-                if (MaxDegreeOfParallelism.HasValue)
+                if (MaxDegreeOfParallelism != 0)
                 {
-                    options.MaxDegreeOfParallelism = MaxDegreeOfParallelism.Value;
+                    options.MaxDegreeOfParallelism = MaxDegreeOfParallelism;
                 }
                 logger.LogTrace("Creating context");
 
@@ -453,9 +453,9 @@ private bool ValidateArguments(CommandRunContext context)
             valid &= ValidateHashAlgorithm(context, FileDigestAlgorithm, "--file-digest");
             valid &= ValidateHashAlgorithm(context, TimestampDigestAlgorithm, "--timestamp-digest");
 
-            if (MaxDegreeOfParallelism is < -1 or 0)
+            if (MaxDegreeOfParallelism < -1)
             {
-                context.Error.WriteLine("'--max-degree-of-parallelism' must be a positive interger, or negative one.");
+                context.Error.WriteLine("'--max-degree-of-parallelism' must be a positive interger, zero, or -1.");
                 valid = false;
             }