-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(tests) Verify runtime deps #460
base: master
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request adds a runtime dependency check to the CI workflow using No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tony - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a step to verify the package installs without errors using
pip install .
oruv pip install .
.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
f4acb11
to
02d4ed0
Compare
Changes
uv run --no-dev
CHANGES
See also
Summary by Sourcery
Adds a CI job to verify runtime dependencies before installing dev dependencies, ensuring the package functions correctly with its declared runtime dependencies.
CI:
uv run --no-dev
before installing dev dependencies.Tests: