Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
sagemathgh-39562: Meson: Remove unused build dependencies ppl and fplll
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Remove ppl and fplll as (build) dependencies according to
sagemath#39548 (comment)
since they are only used via their python wrappers.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39562
Reported by: Tobias Diez
Reviewer(s): Gonzalo Tornaría, Michael Orlitzky
  • Loading branch information
Release Manager committed Mar 8, 2025
2 parents 0cf7694 + 629e10f commit 329829f
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 7 deletions.
4 changes: 1 addition & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ host-requires = [
"pkg:generic/eclib",
"pkg:generic/ecm",
"pkg:generic/fflas-ffpack",
"pkg:generic/fplll",
"pkg:generic/flint",
"pkg:generic/libgd",
"pkg:generic/gap",
Expand Down Expand Up @@ -143,7 +142,6 @@ host-requires = [
"pkg:generic/pari-galdata",
"pkg:generic/pari-seadata",
"pkg:generic/planarity",
"pkg:generic/ppl",
"pkg:generic/primesieve",
"pkg:generic/primecount",
"pkg:generic/qhull",
Expand All @@ -154,10 +152,10 @@ host-requires = [
]

dependencies = [
"pkg:generic/tachyon",
"pkg:generic/sagemath-polytopes-db",
"pkg:generic/sagemath-elliptic-curves",
"pkg:generic/sagemath-graphs",
"pkg:generic/tachyon",
]

[dependency-groups]
Expand Down
3 changes: 0 additions & 3 deletions src/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,8 @@ zlib = dependency('zlib', version: '>=1.2.11')
ec = dependency('eclib', version: '>=20231211')
# Cannot be found via pkg-config
ecm = cc.find_library('ecm')
# Cannot be found via pkg-config
ppl = cc.find_library('ppl')
gmpxx = dependency('gmpxx')
fflas = dependency('fflas-ffpack', version: '>=2.5.0')
fplll = dependency('fplll')
givaro = dependency('givaro', version: '>=4.2.0')
linbox = dependency('linbox', required: false, version: '>=1.7.0')
if not linbox.found()
Expand Down
2 changes: 1 addition & 1 deletion src/sage/libs/linbox/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ foreach name, pyx : extension_data_cpp
install: true,
override_options: ['cython_language=cpp'],
include_directories: [inc_flint],
dependencies: [py_dep, blas, flint, fplll, givaro, gmp, gmpxx, linbox],
dependencies: [py_dep, blas, flint, givaro, gmp, gmpxx, linbox],
)
endforeach

0 comments on commit 329829f

Please sign in to comment.