Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes two issues.
First one related to OpenCore coding style. They defined lots of constant tables as Int32, while values was used is bigger than Int32 max. Since it's just Int32 and UInt32 I've silenced this warning using
-Wno-narrowing
. Better solution would be to fix code in OpenCore.Example:
Also there is no src/get_cce.cpp source file anymore and I just removed it from sources list.
Second issue is linker warning for armeabi-v7a:
It was fixed by
LOCAL_DISABLE_FATAL_LINKER_WARNINGS := true