Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for NDK 20 #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes for NDK 20 #98

wants to merge 1 commit into from

Conversation

molind
Copy link

@molind molind commented Jul 15, 2019

It fixes two issues.

First one related to OpenCore coding style. They defined lots of constant tables as Int32, while values was used is bigger than Int32 max. Since it's just Int32 and UInt32 I've silenced this warning using -Wno-narrowing. Better solution would be to fix code in OpenCore.

Example:

/Users/evgen/git/aac/opencore/codecs_v2/audio/aac/dec/src/analysis_sub_band.cpp:108:18: error: constant expression evaluates to 4268654590 which cannot be narrowed to type 'Int32'
      (aka 'int') [-Wc++11-narrowing]
    0x07D97FC2,  0xFE6E7FFE, 0xF5057F87, 0xEBAB7E60,
                 ^~~~~~~~~~

Also there is no src/get_cce.cpp source file anymore and I just removed it from sources list.

Second issue is linker warning for armeabi-v7a:

[armeabi-v7a] SharedLibrary  : libaacdecoder.so
/Volumes/raid/android/ndk-bundle/toolchains/llvm/prebuilt/darwin-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: warning: shared library text segment is not shareable
/Volumes/raid/android/ndk-bundle/toolchains/llvm/prebuilt/darwin-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: treating warnings as errors

It was fixed by LOCAL_DISABLE_FATAL_LINKER_WARNINGS := true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant