Add capability to camelize QuerySets #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merwok
reviewed
Feb 3, 2017
| new_list = [] | ||
| for i in range(len(data)): | ||
| new_list.append(camelize(data[i])) | ||
| return new_list |
There was a problem hiding this comment.
Isn’t this the same as return [camelize(item) for item in queryset]?
There was a problem hiding this comment.
I see now that this line was inspired by line 21/23 above, where the existing list is modified in place (which is broken for tuples, debatable for lists and already discussed in other tickets).
|
@MattBlack85 this is great idea, we need to set up an integration suite to test this. Also allowing us to test settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to add support when one is using
.values()method on querysets. Actual behaviour is returning the QuerySet since it's not a dict, a list neither a tuple. Now a ValuesQuerySet (deprecated from 1.9, for this reason I check straight for QuerySet instance) can be camelized correctly.Since there is no django setup while running tests I'm not sure how to test it and add this behaviour, but if you have any suggestion @vbabiy I'd be happy to do it