-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web-core): recreate UiDropdown component from DS #8418
base: master
Are you sure you want to change the base?
Conversation
disabled?: boolean | ||
locked?: boolean | ||
selected?: boolean | ||
hover?: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really see the point of having a hover prop here, the hover is already managed in the css, why would we want to add it in a class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the incoming Select component, the hover prop will be used when navigating the select with arrow keys
import { faAngleRight, faLock } from '@fortawesome/free-solid-svg-icons' | ||
import { computed } from 'vue' | ||
|
||
export type DropdownAccent = 'normal' | 'brand' | 'success' | 'warning' | 'danger' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need an export?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any downside of exporting our types. There is no impact on performance or so. And it makes them available if needed.
Wouldn't that be a good idea? Is it keeping a pointer cursor or default when hovering over text instead of having a text cursor? |
Description
Recreate
UiDropdown
component from Design System.Checklist
Fixes #007
,See xoa-support#42
,See https://...
)Introduced by
CHANGELOG.unreleased.md
Review process
Notes: