Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-core): recreate UiDropdown component from DS #8418

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ByScripts
Copy link
Contributor

Description

Recreate UiDropdown component from Design System.

UiDropdown

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@ByScripts ByScripts requested a review from S3bastianCZ March 10, 2025 09:00
@ByScripts ByScripts self-assigned this Mar 10, 2025
disabled?: boolean
locked?: boolean
selected?: boolean
hover?: boolean
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really see the point of having a hover prop here, the hover is already managed in the css, why would we want to add it in a class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the incoming Select component, the hover prop will be used when navigating the select with arrow keys

import { faAngleRight, faLock } from '@fortawesome/free-solid-svg-icons'
import { computed } from 'vue'

export type DropdownAccent = 'normal' | 'brand' | 'success' | 'warning' | 'danger'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need an export?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any downside of exporting our types. There is no impact on performance or so. And it makes them available if needed.

@S3bastianCZ
Copy link
Contributor

Wouldn't that be a good idea? Is it keeping a pointer cursor or default when hovering over text instead of having a text cursor?

@S3bastianCZ S3bastianCZ requested a review from OlivierFL March 10, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants