feat(fs): add azure blob storage #8415
Conversation
@xen-orchestra/fs/src/azure.js
Outdated
| this.#container = parts.shift() | ||
| this.#dir = join(...parts) | ||
| this.#containerClient = this.#blobServiceClient.getContainerClient(this.#container) | ||
| this.#createContainer() |
There was a problem hiding this comment.
you can't call an async method without a await or a then. And you can't call an async method in a constructor. Please move this this in _sync()
@xen-orchestra/fs/src/azure.js
Outdated
| await super._sync() | ||
| await this.#containerClient.createIfNotExists() |
There was a problem hiding this comment.
can you test if this works without retry :
| await super._sync() | |
| await this.#containerClient.createIfNotExists() | |
| await this.#containerClient.createIfNotExists() | |
| await super._sync() |
Co-authored-by: Florent BEAUCHAMP <[email protected]>
Co-authored-by: Florent BEAUCHAMP <[email protected]>
Co-authored-by: Florent BEAUCHAMP <[email protected]>
| const prefix = path === '/' ? '' : path + '/' | ||
| const result = [] | ||
| for await (const item of this.#containerClient.listBlobsByHierarchy('/', { prefix })) { | ||
| const strippedName = item.name.startsWith(`${path}/`) ? item.name.replace(`${path}/`, '') : item.name |
There was a problem hiding this comment.
I think the item.name will always start with prefix , no ?
| } | ||
|
|
||
| const blobClient = this.#containerClient.getBlockBlobClient(file) | ||
| const blockCount = Math.ceil(data.length / MAX_BLOCK_SIZE) |
There was a problem hiding this comment.
the stream don't always have a length property. Please reuse the parameters of s3._outuputStream async _outputStream(path, input, { streamLength, maxStreamLength = streamLength, validator })
|
|
||
| const start = i * MAX_BLOCK_SIZE | ||
| const end = Math.min(start + MAX_BLOCK_SIZE, data.length) | ||
| const chunk = data.slice(start, end) |
There was a problem hiding this comment.
data is a stream, you can't use data.slice here.
You can use readChunkStrict from package @vates/read-chunk to get a part of a stream as a buffer.
| @@ -94,6 +111,12 @@ export const format = ({ type, host, path, port, username, password, domain, pro | |||
| string = protocol === 'https' ? 's3://' : 's3+http://' | |||
| string += `${encodeURIComponent(username)}:${encodeURIComponent(password)}@${host}` | |||
| } | |||
| if (type === 'azure') { | |||
| // used a double slash to seperate path cause password might contain slashes | |||
There was a problem hiding this comment.
slash in password should be encoded by encoreURIComponent
|
|
||
| // list blobs in container | ||
| async _list(path) { | ||
| const prefix = path === '/' ? '' : path + '/' |
There was a problem hiding this comment.
you can use makePrefix if you prefer
| } | ||
|
|
||
| async _rmtree(path) { | ||
| const iter = this.#containerClient.listBlobsFlat({ prefix: path?.endsWith('/') ? path : `${path}/` }) |
There was a problem hiding this comment.
you can use makeprefix here
Description
Short explanation of this PR (feel free to re-use commit message)
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.mdReview process
Notes: